kubernetes-sigs / prow

Prow is a Kubernetes based CI/CD system developed to serve the Kubernetes community. This repository contains Prow source code and Hugo sources for Prow documentation site.
https://docs.prow.k8s.io
Apache License 2.0
127 stars 98 forks source link

Use Cluster and not Manager for build clusters #184

Closed alvaroaleman closed 5 months ago

alvaroaleman commented 5 months ago

At the time controller-runtime was introduced to this project, it didn't have a clean abstraction for "cache + client of a cluster". The only thing it had was the manager, which is that plus some additional things like metrics, webhooks, leader election and code related to run things. As a result, we ended up using the manager and disabling everything it doesn't need.

By now, controller-runtime has the cluster abstraction for precisely this use-case. This change makes us use the cluster where appropriate. It should not result in any outwards-visible behavior changing.

netlify[bot] commented 5 months ago

Deploy Preview for k8s-prow ready!

Name Link
Latest commit 666b131228e6129752de4fd9e0dae3e7e8001e97
Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/66637774683e1a0008f102cd
Deploy Preview https://deploy-preview-184--k8s-prow.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

matthyx commented 5 months ago

/lgtm /hold

droslean commented 5 months ago

/lgtm /approve /hold cancel

Thanks @alvaroaleman !!!!

k8s-ci-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, droslean

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/prow/blob/main/OWNERS)~~ [alvaroaleman,droslean] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment