Closed alvaroaleman closed 5 months ago
Name | Link |
---|---|
Latest commit | 666b131228e6129752de4fd9e0dae3e7e8001e97 |
Latest deploy log | https://app.netlify.com/sites/k8s-prow/deploys/66637774683e1a0008f102cd |
Deploy Preview | https://deploy-preview-184--k8s-prow.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
/lgtm /hold
/lgtm /approve /hold cancel
Thanks @alvaroaleman !!!!
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: alvaroaleman, droslean
The full list of commands accepted by this bot can be found here.
The pull request process is described here
At the time controller-runtime was introduced to this project, it didn't have a clean abstraction for "cache + client of a cluster". The only thing it had was the manager, which is that plus some additional things like metrics, webhooks, leader election and code related to run things. As a result, we ended up using the manager and disabling everything it doesn't need.
By now, controller-runtime has the
cluster
abstraction for precisely this use-case. This change makes us use thecluster
where appropriate. It should not result in any outwards-visible behavior changing.