search

kubernetes-sigs / prow

Prow is a Kubernetes based CI/CD system developed to serve the Kubernetes community. This repository contains Prow source code and Hugo sources for Prow documentation site.
https://docs.prow.k8s.io
Apache License 2.0
127 stars 98 forks source link

feat(pkg/plugins/dco): ignore merged type commits #188

Closed wuhuizuo closed 4 months ago

wuhuizuo commented 5 months ago

Keep same with DCO GitHub app

DCO app will ignore the merge type commits: https://github.com/dcoapp/app/blob/main/lib/dco.js#L15-L19

image

So the branch updating triggered by contributor will not make the DCO check failed.

But the prow's "dco" plugin will fail when the branch has new merge type commits introduced by branch updating.

k8s-ci-robot commented 5 months ago

Hi @wuhuizuo. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
netlify[bot] commented 5 months ago

Deploy Preview for k8s-prow ready!

Name Link
Latest commit e8cb08b8a1fed98aea484866b604c23a199c9288
Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/666c2d830b05d00008e99b8c
Deploy Preview https://deploy-preview-188--k8s-prow.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

droslean commented 5 months ago

/ok-to-test

@wuhuizuo More details about this change would be much appreciated.

wuhuizuo commented 4 months ago

/ok-to-test

@wuhuizuo More details about this change would be much appreciated.

@droslean I added some details in description. PTAL

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droslean, wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/plugins/OWNERS](https://github.com/kubernetes-sigs/prow/blob/main/pkg/plugins/OWNERS)~~ [droslean] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment