Allow `ok-to-test` label to approve GitHub workflow runs for new contributors #25210

kubernetes-sigs / prow

Prow is a Kubernetes based CI/CD system developed to serve the Kubernetes community. This repository contains Prow source code and Hugo sources for Prow documentation site.

https://docs.prow.k8s.io

Apache License 2.0

129 stars 99 forks source link

Allow `ok-to-test` label to approve GitHub workflow runs for new contributors #25210 #194

Open MadhavJivrajani opened 5 months ago

MadhavJivrajani commented 5 months ago

Original Issue: https://github.com/kubernetes/test-infra/issues/25210

What would you like to be added: The ability for Prow to approve GitHub workflow runs after the ok-to-test label has been added to a PR via GitHub's API https://docs.github.com/en/rest/reference/actions#approve-a-workflow-run-for-a-fork-pull-request

Why is this needed: New contributors are blocked from running GitHub workflows even after a maintainer adds the ok-to-test label to a PR and contributors shouldn't need to rely on GUI access to approve workflow runs knative/test-infra/issues/3057

MadhavJivrajani commented 5 months ago

/sig contributor-experience

k8s-triage-robot commented 2 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue as fresh with /remove-lifecycle stale
Close this issue with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

tuminoid commented 2 months ago

/remove-lifecycle stale This is still valid request. There is a workaround, but it would be nicer if it was an actual feature in Prow.

JesseStutler commented 1 month ago

I'm from volcano community, we also wish to have this feature. Currently, the first PR from outside contributors must be approved by our owner and then trigger the github workflows, which contain some e2e testing. We wish that when there is /ok-to-test labeled, the workflows can be triggered, not keep waiting for the owner to approve.

JesseStutler commented 1 month ago

Hi, @tuminoid , how do you solve this problem? Are there any best practices so far? Thanks.

tuminoid commented 1 month ago

Hi, @tuminoid , how do you solve this problem? Are there any best practices so far? Thanks.

We are using this: https://github.com/kubernetes/test-infra/issues/25210#issuecomment-2039476449 as there is no better alternative right now.

JesseStutler commented 1 month ago

OK, thanks, I think currently this action is enough to help our community, hope that prow will implement this feature one day. Seems that there are multiple communities hoping to combine prow and github workflows.