search

kubernetes-sigs / prow

Prow is a Kubernetes based CI/CD system developed to serve the Kubernetes community. This repository contains Prow source code and Hugo sources for Prow documentation site.
https://docs.prow.k8s.io
Apache License 2.0
130 stars 99 forks source link

Prow seems to assign Assignees who are not in OWNERS file #199

Open adelton opened 5 months ago

adelton commented 5 months ago

In https://github.com/opendatahub-io/notebooks/pull/587, after adding my LGTM review, openshift-ci (bot) came and "assigned adelton" as Assignee.

I'm not even listed in https://github.com/opendatahub-io/notebooks/blob/main/OWNERS so this is quite surprising and does not seem to match the referenced pull request process at https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md#the-code-review-process.

Should the prow behaviour (perhaps in https://github.com/kubernetes-sigs/prow/tree/main/pkg/plugins/assign) be modified, or should this be brought for clarification to https://github.com/kubernetes/community/?

petr-muller commented 5 months ago

Right, Prow does that for approvers after they approve a PR. I am actually not sure why it does that :D I'm not sure how your Prow is configured, it can be configured to consider GH approves as Prow approves, which I think is the case here; your review was a GH approve.

jiridanek commented 5 months ago

For completeness, here's our Prow configs for the repo.

First, https://github.com/openshift/release/tree/master/ci-operator/config/opendatahub-io/notebooks (that's just CI jobs, probably not relevant).

And second, here's our global prow config https://github.com/openshift/release/blob/master/core-services/prow/02_config/_config.yaml and here's the repo specific config https://github.com/openshift/release/blob/master/core-services/prow/02_config/opendatahub-io/notebooks/_prowconfig.yaml and plugin config https://github.com/openshift/release/blob/master/core-services/prow/02_config/opendatahub-io/notebooks/_pluginconfig.yaml

BenTheElder commented 4 months ago

I am actually not sure why it does that :D

It's just Kubernetes's workflow, to assign people that take over the review / approval. It gives more visibility.

NOTE: anyone can /assign anyhow.

k8s-triage-robot commented 1 month ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 3 days ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten