search

kubernetes-sigs / prow

Prow is a Kubernetes based CI/CD system developed to serve the Kubernetes community. This repository contains Prow source code and Hugo sources for Prow documentation site.
https://docs.prow.k8s.io
Apache License 2.0
127 stars 98 forks source link

Update github.com/prometheus/common module #200

Closed danilo-gemoli closed 4 months ago

danilo-gemoli commented 4 months ago

As per title, update the prometheus/common module:

go get github.com/prometheus/common@v0.54.0

What follow is the sole breaking change I have hit. The field:

expfmt.FmtProtoDelim

is no longer public and it has been replaced by this function:

expfmt.NewFormat(expfmt.TypeProtoDelim)

They both result in the same string:

fmtProtoDelim        Format = protoFmt + ` encoding=delimited`

so we should be safe.

Check https://github.com/prometheus/common/pull/576 for more information.

netlify[bot] commented 4 months ago

Deploy Preview for k8s-prow ready!

Name Link
Latest commit 2f31c504cb488a018e45cb7ee26767879c1d848d
Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/667d1d06e233af0008f188db
Deploy Preview https://deploy-preview-200--k8s-prow.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

danilo-gemoli commented 4 months ago

/retest-required

danilo-gemoli commented 4 months ago

We are running out of resources:

There are no nodes that your pod can schedule to - check your requests, tolerations, and node selectors (0/46 nodes are available: 3 node(s) had untolerated taint {node-group: stable}, 43 Insufficient cpu. preemption: 0/46 nodes are available: 3 Preemption is not helpful for scheduling, 43 No preemption victims found for incoming pod..)
danilo-gemoli commented 4 months ago

/retest-required

droslean commented 4 months ago

/retest

droslean commented 4 months ago

/lgtm /approve

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danilo-gemoli, droslean

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/prow/blob/main/OWNERS)~~ [droslean] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment