Closed MadhavJivrajani closed 2 months ago
We also have a bot that runs every 24h (originally every 10m) that checks the CLA labels and triggers a check: https://github.com/kubernetes/test-infra/blob/b89b3769f19b8f990a1ad64c547375373cca995e/config/jobs/kubernetes/sig-k8s-infra/trusted/sig-contribex-k8s-triage-robot.yaml#L90
Nvm
CLA plugin also adds in the labels which we need.
AFAICT, the comment that we now use to refresh and check CLA status on a PR is
/easycla
whose implementation is owned and managed by EasyCLA and LF.The CLA plugin as it is currently also checks for the
EasyCLA
context https://github.com/kubernetes-sigs/prow/blob/79d27b6e3be35974fbe103d3f574d70dfea6f03c/pkg/plugins/cla/cla.go#L36when you comment
/check-cla
: https://github.com/kubernetes-sigs/prow/blob/79d27b6e3be35974fbe103d3f574d70dfea6f03c/pkg/plugins/cla/cla.go#L41That said, do we still need the
cla
plugin provided we've fully moved onto EasyCLA and that has been operating smoothly for over half a year atleast?/sig contributor-experience /cc @palnabarun @Priyankasaggu11929 @kaslin current ContribEx leadas /cc @mrbobbytables @cblecker @nikhita @jberkus for historical context if any