search

kubernetes-sigs / prow

Prow is a Kubernetes based CI/CD system developed to serve the Kubernetes community. This repository contains Prow source code and Hugo sources for Prow documentation site.
https://docs.prow.k8s.io
Apache License 2.0
129 stars 99 forks source link

Fix assign plugins #206

Closed Okabe-Junya closed 4 months ago

Okabe-Junya commented 4 months ago

this PR is following up to #164

Bug Description

ListTeamMembersBySlug function requires org and teamSlug as arguments, but I mistakenly passed org and login as arguments.

teamMembers, err := h.gc.ListTeamMembersBySlug(org, login, "all")

Meaning, I was passing arguments like kubernetes, kubernetes/sig-misc-approvers - The correct arguments are kubernetes, sig-misc-approvers

Change List

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Okabe-Junya Once this PR has been reviewed and has the lgtm label, please assign cjwagner for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[pkg/plugins/OWNERS](https://github.com/kubernetes-sigs/prow/blob/main/pkg/plugins/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
netlify[bot] commented 4 months ago

Deploy Preview for k8s-prow ready!

Name Link
Latest commit efa0c90d8053042b22b95d7fe8ec17411bcf7e48
Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/6686e74ac96b240008b403b0
Deploy Preview https://deploy-preview-206--k8s-prow.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Okabe-Junya commented 4 months ago

/assign droslean

droslean commented 4 months ago

/label tide/merge-method-squash

droslean commented 4 months ago

@Okabe-Junya Is this the fix for https://github.com/kubernetes-sigs/prow/issues/204 ?

Okabe-Junya commented 4 months ago

@droslean

It's not certain, but since this code clearly contains a bug, I think it's a good to move this PR forward.

ref. https://github.com/kubernetes-sigs/prow/issues/204#issuecomment-2209429428

droslean commented 4 months ago

@Okabe-Junya It would be better to revert the whole feature and you can open another PR to re-introduce it with the fix as well.

droslean commented 4 months ago

/hold

Okabe-Junya commented 4 months ago

Ok, closing this PR and create another one

/close

k8s-ci-robot commented 4 months ago

@Okabe-Junya: Closed this PR.

In response to [this](https://github.com/kubernetes-sigs/prow/pull/206#issuecomment-2222464577): >Ok, closing this PR and create another one > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.