search

kubernetes-sigs / prow

Prow is a Kubernetes based CI/CD system developed to serve the Kubernetes community. This repository contains Prow source code and Hugo sources for Prow documentation site.
https://docs.prow.k8s.io
Apache License 2.0
129 stars 99 forks source link

Specify the image file for image build/push. #217

Closed michelle192837 closed 3 months ago

michelle192837 commented 3 months ago

The default is prow/.prow-images.yaml, which made sense when Prow was in k8s/test-infra since it was nested in a subdirectory, but doesn't make sense anymore now that the files are unnested in their own repo. We could update the default instead, but I think having the argument here explicitly is clearer in this crops up again in future.

I believe this should fix the image push job for Prow images (post-k8s-infra-prow-images), which doesn't have any published images in k8s-staging-test-infra yet.

Ref https://github.com/kubernetes/test-infra/issues/32432

netlify[bot] commented 3 months ago

Deploy Preview for k8s-prow ready!

Name Link
Latest commit 7fb35856130e9014b4ed047b1b90f0227a7f874e
Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/66ad3cceb70c2b0008d498b5
Deploy Preview https://deploy-preview-217--k8s-prow.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ameukam commented 3 months ago

/lgtm

matthyx commented 3 months ago

/approve

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matthyx, michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/prow/blob/main/OWNERS)~~ [matthyx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
michelle192837 commented 3 months ago

Update: I am actually just bad at finding images (I thought I couldn't find them in Artifact Registry, but they are being published correctly under the specified path at us-docker.pkg.dev/k8s-infra-prow/images/), and confused the default in k8s/test-infra with the default in this repo's version of hack/prowimagebuilder (which correctly points to the same file).

In any case, this job has been working and is still working after the change (which should be a no-op). Sorry for the confusion!