search

kubernetes-sigs / prow

Prow is a Kubernetes based CI/CD system developed to serve the Kubernetes community. This repository contains Prow source code and Hugo sources for Prow documentation site.
https://docs.prow.k8s.io
Apache License 2.0
129 stars 99 forks source link

cherrypickapproved: implement org-level configuration #232

Closed xmudrii closed 2 months ago

xmudrii commented 3 months ago

This PR implements the org-level configuration for the cherrypickapproved plugin. Right now, it's possible to configure this plugin only on the repo-level. If you have multiple repos, you have to repeat the config for each repo, which is inefficient and clutters the configuration file, especially if the config is the same for all repos.

With this PR, such a configuration is allowed:

cherry_pick_approved:
  - org: org-name
    branchregexp: '^release/v.*$'
    approvers:
      - ...

The repo-level config has the priority over the org level configuration. This also means that this is not a breaking change, i.e. the existing configurations will continue working as before.

/assign @saschagrunert cc @kubernetes-sigs/release-engineering

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/plugins/cherrypickapproved/OWNERS](https://github.com/kubernetes-sigs/prow/blob/main/pkg/plugins/cherrypickapproved/OWNERS)~~ [xmudrii] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
netlify[bot] commented 3 months ago

Deploy Preview for k8s-prow ready!

Name Link
Latest commit ed8a5a0c7ef060994b05d9cfd0f5f8b7d2177310
Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/66bf40069eef93000887ad83
Deploy Preview https://deploy-preview-232--k8s-prow.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

xmudrii commented 3 months ago

/test pull-prow-unit-test-race-detector-nonblocking

matthyx commented 3 months ago

@xmudrii you might want to take a look at https://github.com/kubernetes-sigs/prow/pull/147 where I'm trying to propose a generic solution that could be applied to all plugins

xmudrii commented 2 months ago

In addition to https://github.com/kubernetes-sigs/prow/pull/147, I'd like that we take a different route here, so I'm going to close this PR and start over again if needed. /close

k8s-ci-robot commented 2 months ago

@xmudrii: Closed this PR.

In response to [this](https://github.com/kubernetes-sigs/prow/pull/232#issuecomment-2312520595): >In addition to https://github.com/kubernetes-sigs/prow/pull/147, I'd like that we take a different route here, so I'm going to close this PR and start over again if needed. >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.