kubernetes-sigs / prow

Prow is a Kubernetes based CI/CD system developed to serve the Kubernetes community. This repository contains Prow source code and Hugo sources for Prow documentation site.
https://docs.prow.k8s.io
Apache License 2.0
130 stars 99 forks source link

gangway: Add ListJobExecutions implementation #244

Closed diconico07 closed 1 month ago

diconico07 commented 3 months ago

This PR actually implements the yet unimplemented but defined ListJobExecutions method for gangway.

As I didn't find any specific documentation about how it should behave with regards to authentication, I chose to do as for the GetJobExecution and not enforce the allowed_jobs_filters for a RO operation.

linux-foundation-easycla[bot] commented 3 months ago

CLA Signed

The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 3 months ago

Welcome @diconico07!

It looks like this is your first PR to kubernetes-sigs/prow 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/prow has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 3 months ago

Hi @diconico07. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
netlify[bot] commented 3 months ago

Deploy Preview for k8s-prow ready!

Name Link
Latest commit baf29c33f6045bbc4ebc6b01a8ae1051989efcdb
Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/66fd163e1881ed0008b2d673
Deploy Preview https://deploy-preview-244--k8s-prow.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Prucek commented 2 months ago

/ok-to-test

diconico07 commented 2 months ago

Added integration tests, and applied the modifications you asked for

Prucek commented 2 months ago

Added integration tests, and applied the modifications you asked for

@diconico07 Sorry but I don't see an integration test in this PR, and I think the documentation part (pkg/plugins/plugin-config-documented.yaml) added is a mistake?

diconico07 commented 2 months ago

@Prucek indeed, git add mistake, added the wrong file, now the integration test is here

Prucek commented 1 month ago

From my site, it's: /lgtm Thanks @diconico07 for working on it. @petr-muller could you take a look at it for approval?

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: diconico07, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/prow/blob/main/OWNERS)~~ [petr-muller] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment