search

kubernetes-sigs / prow

Prow is a Kubernetes based CI/CD system developed to serve the Kubernetes community. This repository contains Prow source code and Hugo sources for Prow documentation site.
https://docs.prow.k8s.io
Apache License 2.0
129 stars 99 forks source link

prowjob CRD is too large to apply #256

Open BenTheElder opened 3 months ago

BenTheElder commented 3 months ago

We're including all of the descriptions of pod fields in the embedded podspec, I think we can just drop those and have a single top level description pointing to the upstream pod type?

see: https://github.com/kubernetes/kubernetes/issues/54579#issuecomment-2014891144

cc @jpbetz

the CRD is in https://github.com/kubernetes-sigs/prow/blob/main/config/prow/cluster/prowjob-crd/prowjob_customresourcedefinition.yaml

We ran into this while spinning up the new k8s infra instance today.

It looks like SSA is being used as a workaround: https://github.com/kubernetes/test-infra/blob/ccb09026bddecdc4ff7089f34027897d0e764d5d/config/prow/Makefile#L35

matthyx commented 3 months ago

cross linking previous issue https://github.com/kubernetes-sigs/prow/issues/181

xrstf commented 1 month ago

It's ugly and brute force, but one could also strip all descriptions from the YAML.