Closed smg247 closed 2 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: smg247 Once this PR has been reviewed and has the lgtm label, please assign cjwagner for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Name | Link |
---|---|
Latest commit | 96e88c5c121cfd7722cbbf01944e5d17b85a9913 |
Latest deploy log | https://app.netlify.com/sites/k8s-prow/deploys/66e1d69d5255c70008ed766d |
Deploy Preview | https://deploy-preview-273--k8s-prow.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Since there is no way to exclude the plugin from functioning on the repo
This isn't true since February 2021. Check out the excluded_repos
field in the plugin configuration.
https://github.com/kubernetes/test-infra/issues/20631, https://github.com/kubernetes/test-infra/pull/20707
Since there is no way to exclude the plugin from functioning on the repo
This isn't true since February 2021. Check out the
excluded_repos
field in the plugin configuration. kubernetes/test-infra#20631, kubernetes/test-infra#20707
Ah, thanks for pointing that out. I even went searching for something like that and couldn't find anything.
We won't need this after all then
/close
@smg247: Closed this PR.
From what I can tell the validation is incomplete and needs to be improved to account for excluded_repos. Maybe we just haven't encountered this case before.
That is my conclusion as well. I do think that fixing that validation is a better solution than what I have done with this PR, so I will take that approach instead.
There is a situation where a repository doesn't want
blunderbuss
, but it is configured at the org level. Since there is no way to exclude the plugin from functioning on the repo, we must have some way to disable the functionality assigning reviewers. We can do this by allowingrequest_count
to be0
For: https://issues.redhat.com/browse/DPTP-4164