search

kubernetes-sigs / prow

Prow is a Kubernetes based CI/CD system developed to serve the Kubernetes community. This repository contains Prow source code and Hugo sources for Prow documentation site.
https://docs.prow.k8s.io
Apache License 2.0
127 stars 98 forks source link

fix `validatePluginsDupes` to account for `excluded_repos` #275

Closed smg247 closed 2 months ago

smg247 commented 2 months ago

Excluded repos are still validated for duplicate plugin configuration against their org. This prevents the possibility to exclude a repo from an org's plugin configuration, and then select some of the plugins that the org has enabled in the repo's configuration.

Discovered this issue from trying to use the excluded_repos configuration after abandoning the functionality in https://github.com/kubernetes-sigs/prow/pull/273.

netlify[bot] commented 2 months ago

Deploy Preview for k8s-prow ready!

Name Link
Latest commit 04e3df622f870189e630aced13d8c71f7c2b7901
Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/66e4350f7124810008173663
Deploy Preview https://deploy-preview-275--k8s-prow.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

smg247 commented 2 months ago

@cjwagner, are you able to take a look at this?

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjwagner, smg247

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/plugins/OWNERS](https://github.com/kubernetes-sigs/prow/blob/main/pkg/plugins/OWNERS)~~ [cjwagner] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment