search

kubernetes-sigs / prow

Prow is a Kubernetes based CI/CD system developed to serve the Kubernetes community. This repository contains Prow source code and Hugo sources for Prow documentation site.
https://docs.prow.k8s.io
Apache License 2.0
129 stars 99 forks source link

add workflow_call triggered workflows to failed workflow search #277

Closed tuminoid closed 2 months ago

tuminoid commented 2 months ago

We want to rerun workflows that we're triggered by workflow_call with Prow's /retest keyword, when trigger_github_workflows: true is enabled in plugin config.

Fixes: #276

netlify[bot] commented 2 months ago

Deploy Preview for k8s-prow ready!

Name Link
Latest commit b9597486fedb83f3d4946508c04858762a18b056
Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/66e90d34164b3c00080621c7
Deploy Preview https://deploy-preview-277--k8s-prow.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tuminoid commented 2 months ago

/retest

tuminoid commented 2 months ago

wanna add a unit test?

There are no unit tests for this function to simply expand, so before adding them I'm looking for comments that agree that this is OK, and not breaking some other use-case I'm not expecting.

krzyzacy commented 2 months ago

wanna add a unit test?

There are no unit tests for this function to simply expand, so before adding them I'm looking for comments that agree that this is OK, and not breaking some other use-case I'm not expecting.

Could you run a query and check how many workflow_call are in the kubernetes org? (to make sure it's not going to be a huge load, in case this impacts the GH token limit, cc @cjwagner)

tuminoid commented 2 months ago

wanna add a unit test?

There are no unit tests for this function to simply expand, so before adding them I'm looking for comments that agree that this is OK, and not breaking some other use-case I'm not expecting.

Could you run a query and check how many workflow_call are in the kubernetes org? (to make sure it's not going to be a huge load, in case this impacts the GH token limit, cc @cjwagner)

0 in sigs: https://github.com/search?q=org%3Akubernetes-sigs+workflow_call%3A&type=code
2 in k8s: https://github.com/search?q=org%3Akubernetes+workflow_call%3A&type=code

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krzyzacy, tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/OWNERS](https://github.com/kubernetes-sigs/prow/blob/main/pkg/OWNERS)~~ [krzyzacy] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment