search

kubernetes-sigs / prow

Prow is a Kubernetes based CI/CD system developed to serve the Kubernetes community. This repository contains Prow source code and Hugo sources for Prow documentation site.
https://docs.prow.k8s.io
Apache License 2.0
129 stars 99 forks source link

Update to controller-runtime 0.18.5 / Kube 1.30 #286

Closed xrstf closed 1 month ago

xrstf commented 1 month ago

This is a mostly painless upgrade, except that it took me 2 hours to find the note that WatchRawSource() doesn't respect global predicates anymore :sweat_smile: I had to split the existing predicate in plank into two implementations to adjust for that.

k8s-ci-robot commented 1 month ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

xrstf commented 1 month ago

/test all

netlify[bot] commented 1 month ago

Deploy Preview for k8s-prow ready!

Name Link
Latest commit 95f9c615b7f5c8751be561b3a6efac760bad59f4
Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/66fec528f34a3400086e2664
Deploy Preview https://deploy-preview-286--k8s-prow.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

xrstf commented 1 month ago

/test all

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/prow/blob/main/OWNERS)~~ [petr-muller] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment