search

kubernetes-sigs / prow

Prow is a Kubernetes based CI/CD system developed to serve the Kubernetes community. This repository contains Prow source code and Hugo sources for Prow documentation site.
https://docs.prow.k8s.io
Apache License 2.0
129 stars 99 forks source link

(spyglass/lenses) allow configuration sandbox permissions #296

Open norrs opened 1 month ago

norrs commented 1 month ago

This provides the ability to configure iframe sandbox permissions pr lense. This allows the operator of the prow installation to define which permissions it trust to each lense.

PR comes from the ideas and discussions in https://github.com/kubernetes-sigs/prow/pull/294

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: norrs Once this PR has been reviewed and has the lgtm label, please assign smg247, stevekuznetsov for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[cmd/checkconfig/OWNERS](https://github.com/kubernetes-sigs/prow/blob/main/cmd/checkconfig/OWNERS)** - **[cmd/deck/OWNERS](https://github.com/kubernetes-sigs/prow/blob/main/cmd/deck/OWNERS)** - **[pkg/spyglass/OWNERS](https://github.com/kubernetes-sigs/prow/blob/main/pkg/spyglass/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 1 month ago

Hi @norrs. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
netlify[bot] commented 1 month ago

Deploy Preview for k8s-prow ready!

Name Link
Latest commit 2377f0e61ed75d758db50c9c622187d85291c23d
Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/6707d9c989373900087a9d68
Deploy Preview https://deploy-preview-296--k8s-prow.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

michelle192837 commented 3 weeks ago

/ok-to-test

norrs commented 3 days ago

Do you need anything more from me on this?