Update code-generator to 1.30.1

xrstf commented 1 month ago

While working on #293, I noticed I had to bump the code-generator as well, which blew up that PR more than it should. So this PR extracts just the code-generator update.

The code generator was significantly outdated and was updated to match the current set of Kube dependencies (i.e. 1.30.x). Notably:

The entire GOPATH cloning logic was removed; all generators are now compatible with Go modules and there is no need anymore to ensure a GOPATH-like setup (I ran everything locally in ~/projects/prow).
The GOPATH magic mentions bazel peculiarities as one of the reasons for the complexity. I could not immediate see where exactly Bazel is currently used in Prow, so I simply chose to ignore it and see which wall I would hit. :grin: Bazel support seems to have been removed 2 years ago via https://github.com/kubernetes/test-infra/pull/26039.
Not working in a mirrored version also fixed the bindata generation: That step never actually copied the files back to the repository and so we never noticed that someone manually fixed the %v to be %w, because go-bindata 3.1.3 (latest) still outputs %v.

k8s-ci-robot commented 1 month ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

netlify[bot] commented 1 month ago

Deploy Preview for k8s-prow ready!

Name	Link
Latest commit	3c469984bdbf81036ce3267232574b98e944eaed
Latest deploy log	https://app.netlify.com/sites/k8s-prow/deploys/670ba7c1d10710000872e894
Deploy Preview	https://deploy-preview-298--k8s-prow.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

xrstf commented 1 month ago

/test all

petr-muller commented 1 month ago

/cc

xrstf commented 2 weeks ago

@petr-muller This is currently blocking my other PRs :-)

k8s-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/prow/blob/main/OWNERS)~~ [petr-muller] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kubernetes-sigs / prow