search

kubernetes-sigs / prow

Prow is a Kubernetes based CI/CD system developed to serve the Kubernetes community. This repository contains Prow source code and Hugo sources for Prow documentation site.
https://docs.prow.k8s.io
Apache License 2.0
129 stars 99 forks source link

fix race condition when loading multiple cluster contexts #299

Closed xrstf closed 1 month ago

xrstf commented 1 month ago

Setting up a new cache will apply default values. If multiple clients share the same options, ultimately the client.New() call would race to setup the namespace cache options.

The issue was introduced with a recent controller-runtime update in Prow.

Fixes #288

netlify[bot] commented 1 month ago

Deploy Preview for k8s-prow ready!

Name Link
Latest commit 50dd168d0bd6ea5fe938eeecc14d4c841c2cbf72
Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/670bd2e86d980200085df4a7
Deploy Preview https://deploy-preview-299--k8s-prow.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/OWNERS](https://github.com/kubernetes-sigs/prow/blob/main/pkg/OWNERS)~~ [petr-muller] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment