search

kubernetes-sigs / prow

Prow is a Kubernetes based CI/CD system developed to serve the Kubernetes community. This repository contains Prow source code and Hugo sources for Prow documentation site.
https://docs.prow.k8s.io
Apache License 2.0
129 stars 99 forks source link

`tide`: follow up to optional context regex field #304

Closed smg247 closed 1 month ago

smg247 commented 1 month ago

modify optional context regex logic to only compile the regexp on load, and fix it so it is properly loaded and merged

This is a follow up to: https://github.com/kubernetes-sigs/prow/pull/303

netlify[bot] commented 1 month ago

Deploy Preview for k8s-prow ready!

Name Link
Latest commit 57eb4652043e787d7e1c818be01cb1d0e68bebd3
Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/6712957ae8c8860008be71ea
Deploy Preview https://deploy-preview-304--k8s-prow.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

droslean commented 1 month ago

/lgtm /approve

/hold

Holding for @petr-muller to take a look.

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droslean, petr-muller, smg247

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/OWNERS](https://github.com/kubernetes-sigs/prow/blob/main/pkg/OWNERS)~~ [droslean,petr-muller] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment