search

kubernetes-sigs / prow

Prow is a Kubernetes based CI/CD system developed to serve the Kubernetes community. This repository contains Prow source code and Hugo sources for Prow documentation site.
https://docs.prow.k8s.io
Apache License 2.0
129 stars 99 forks source link

[scheduler] include the pj labels on the external strategy #310

Closed droslean closed 3 weeks ago

droslean commented 3 weeks ago

The external strategy sends only the job name as a request. With this change, the prowjob's labels are also included.

/cc @danilo-gemoli @jmguzik Signed-off-by: Nikolaos Moraitis nmoraiti@redhat.com

k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droslean

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/OWNERS](https://github.com/kubernetes-sigs/prow/blob/main/pkg/OWNERS)~~ [droslean] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
netlify[bot] commented 3 weeks ago

Deploy Preview for k8s-prow ready!

Name Link
Latest commit 9069c20e7bcbe9e581f139ecb8c20fd507b5016e
Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/6720d142af40f6000820c7de
Deploy Preview https://deploy-preview-310--k8s-prow.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

droslean commented 3 weeks ago

/hold

droslean commented 3 weeks ago

/close

k8s-ci-robot commented 3 weeks ago

@droslean: Closed this PR.

In response to [this](https://github.com/kubernetes-sigs/prow/pull/310#issuecomment-2444070913): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.