search

kubernetes-sigs / prow

Prow is a Kubernetes based CI/CD system developed to serve the Kubernetes community. This repository contains Prow source code and Hugo sources for Prow documentation site.
https://docs.prow.k8s.io
Apache License 2.0
129 stars 99 forks source link

Revert "`deck`: don't serve the ready endpoint until immediately prior to starting the server" #316

Closed petr-muller closed 2 weeks ago

petr-muller commented 2 weeks ago

Reverts kubernetes-sigs/prow#308

https://github.com/kubernetes-sigs/prow/pull/308#issuecomment-2457656048

Stephen Goeddel 3 minutes ago New deck never becomes ready. I am going to try some additional logging with a locally built version, but will most likely reverting the bump (and the PR)

k8s-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/prow/blob/main/OWNERS)~~ [petr-muller] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
netlify[bot] commented 2 weeks ago

Deploy Preview for k8s-prow ready!

Name Link
Latest commit 799e657802ae5e16edd65794c4eda4555d12c862
Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/672a60d4e25277000866d85b
Deploy Preview https://deploy-preview-316--k8s-prow.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

smg247 commented 2 weeks ago

/lgtm