search

kubernetes-sigs / prow

Prow is a Kubernetes based CI/CD system developed to serve the Kubernetes community. This repository contains Prow source code and Hugo sources for Prow documentation site.
https://docs.prow.k8s.io
Apache License 2.0
129 stars 99 forks source link

Update aws sdk code from v1 to v2 #322

Closed dims closed 1 week ago

dims commented 1 week ago

Tested the method getS3Bucket locally using work credentials (empty s3Credentials essentially)

had to update gocloud.dev/blob to a version that supports aws sdk v2

xref: https://github.com/kubernetes-sigs/prow/issues/212

netlify[bot] commented 1 week ago

Deploy Preview for k8s-prow ready!

Name Link
Latest commit 77dc7b725f136fed43a3c01e90a70d3f89ae92f2
Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/67338e8d8347d5000882f231
Deploy Preview https://deploy-preview-322--k8s-prow.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dims commented 1 week ago

cc @micahhausler

dims commented 1 week ago

/assign @stevekuznetsov @krzyzacy

dims commented 1 week ago

@krzyzacy we use a custom format for the creds config - https://github.com/dims/prow/blob/b21d1cf485474d6da2623ccc40849e2c8b24b2e5/pkg/io/providers/providers.go#L97-L107

So i don't think we need any changes in the job configs (famous last words!)

k8s-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, krzyzacy, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/prow/blob/main/OWNERS)~~ [krzyzacy,petr-muller] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dims commented 1 week ago

@petr-muller @krzyzacy i am one of the folks who keep an eye on things failing. want to land this (and happy to revert immediately if anything fails). I am NOT at kubecon as well, might as well do this exercise before folks return from there.

krzyzacy commented 1 week ago

lol sorry I meant to let you unhold yourself, but :shipit:

/unhold