kubernetes-sigs / prow

Prow is a Kubernetes based CI/CD system developed to serve the Kubernetes community. This repository contains Prow source code and Hugo sources for Prow documentation site.
https://docs.prow.k8s.io
Apache License 2.0
129 stars 99 forks source link

trigger: improve experience of guided comment #323

Closed wuhuizuo closed 6 days ago

wuhuizuo commented 1 week ago

Fixes #321

Signed-off-by: wuhuizuo wuhuizuo@126.com

k8s-ci-robot commented 1 week ago

Hi @wuhuizuo. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
netlify[bot] commented 1 week ago

Deploy Preview for k8s-prow ready!

Name Link
Latest commit 49b4630ac1a48fb8c0cc6d8534808570ad86e806
Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/6736f4484915500008ac3ec6
Deploy Preview https://deploy-preview-323--k8s-prow.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

k8s-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/OWNERS](https://github.com/kubernetes-sigs/prow/blob/main/pkg/OWNERS)~~ [petr-muller] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
petr-muller commented 1 week ago

/lgtm cancel

Needs unit tests fixed

wuhuizuo commented 1 week ago

/retest-required

k8s-ci-robot commented 1 week ago

@wuhuizuo: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/kubernetes-sigs/prow/pull/323#issuecomment-2478102403): >/retest-required Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
wuhuizuo commented 1 week ago

I fixed the unit test, and run them passed in local except the pkg/kube package.

/lgtm cancel

Needs unit tests fixed

wuhuizuo commented 1 week ago

My development env is on a kubernetes pod, the pkg/kube test can not pass on my env.

stevekuznetsov commented 6 days ago

/ok-to-test /lgtm

wuhuizuo commented 6 days ago

The failure of integration job looks not caused by this PR.

/retest