Closed wuhuizuo closed 6 days ago
Hi @wuhuizuo. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Name | Link |
---|---|
Latest commit | 49b4630ac1a48fb8c0cc6d8534808570ad86e806 |
Latest deploy log | https://app.netlify.com/sites/k8s-prow/deploys/6736f4484915500008ac3ec6 |
Deploy Preview | https://deploy-preview-323--k8s-prow.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: petr-muller, wuhuizuo
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm cancel
Needs unit tests fixed
/retest-required
@wuhuizuo: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test
message.
I fixed the unit test, and run them passed in local except the pkg/kube
package.
/lgtm cancel
Needs unit tests fixed
My development env is on a kubernetes pod, the pkg/kube
test can not pass on my env.
/ok-to-test /lgtm
The failure of integration job looks not caused by this PR.
/retest
Fixes #321
Signed-off-by: wuhuizuo wuhuizuo@126.com