Tune Makefile and Travis config

kubernetes-sigs / reference-docs

Tools to build reference documentation for Kubernetes APIs and CLIs.

Apache License 2.0

90 stars 105 forks source link

Tune Makefile and Travis config #228

Closed tengqm closed 3 years ago

tengqm commented 3 years ago

This PR tunes the Makefile by:

improve detection of K8S_RELEASE environment variable and error/abort if not defined;
add new targets configapi and copy-configapi;
add configapi, genresources into the target list;
move constant definition to where they belong;
remove the RCNUM variable which is not used anywhere.

The PR tunes the travis configuration by:

replace the KUBE_VERSION environemnt variable by K8S_RELEASE for consistency;
upgrade go version from 1.15.5 to 1.16.3 which is the default version used by the upstream community/repo;
add api, configapi into list of scripts to be executed.

kbhawkey commented 3 years ago

Hold for review /hold

kbhawkey commented 3 years ago

/lgtm

kbhawkey commented 3 years ago

Did the new targets build as expected (check the Travis log)?

tengqm commented 3 years ago

@kbhawkey Yes. It works as expected. I don't know how to check the output produced though.

kbhawkey commented 3 years ago

/approve /hold cancel

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/reference-docs/blob/master/OWNERS)~~ [kbhawkey,tengqm] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment