search

kubernetes-sigs / reference-docs

Tools to build reference documentation for Kubernetes APIs and CLIs.
Apache License 2.0
90 stars 105 forks source link

gen-compdocs: update to 1.23.0 #259

Closed pohly closed 2 years ago

pohly commented 2 years ago

This is currently the latest release. Something like this PR should be needed to update https://github.com/kubernetes/website/commits/dev-1.23/content/en/docs/reference/command-line-tools-reference/

If not, feel free to close it.

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pohly To complete the pull request process, please assign sftim after the PR has been reviewed. You can assign the PR to them by writing /assign @sftim in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/reference-docs/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kbhawkey commented 2 years ago

@pohly , Is it okay if we close this PR? The 1.23.0 release tag is available. Thanks.

kbhawkey commented 2 years ago

/hold

pohly commented 2 years ago

Doesn't someone still need to update the command line tools reference for 1.23? The last update seems to be for 1.22:

https://github.com/kubernetes/website/commits/dev-1.23/content/en/docs/reference/command-line-tools-reference/kube-apiserver.md

If yes, then a PR like this will be needed.

tengqm commented 2 years ago

@pohly I think @kbhawkey has already updated the build facilities for kubectl? https://github.com/kubernetes-sigs/reference-docs/pull/266

pohly commented 2 years ago

I think @kbhawkey has already updated the build facilities for kubectl?

Yes. But isn't this directory for the other tools (kube-controller-manager, kube-proxy, etc.)?

kbhawkey commented 2 years ago

I think @kbhawkey has already updated the build facilities for kubectl?

Yes. But isn't this directory for the other tools (kube-controller-manager, kube-proxy, etc.)?

Hi @pohly . Yes, PR https://github.com/kubernetes-sigs/reference-docs/pull/264 updates the go.mod and go.sum files for the gen-compdocs build. Does this make sense?

k8s-ci-robot commented 2 years ago

@pohly: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
pohly commented 2 years ago

This PR is not needed anymore because https://github.com/kubernetes-sigs/reference-docs/pull/264 got merged instead.

/close

k8s-ci-robot commented 2 years ago

@pohly: Closed this PR.

In response to [this](https://github.com/kubernetes-sigs/reference-docs/pull/259#issuecomment-990667537): >This PR is not needed anymore because https://github.com/kubernetes-sigs/reference-docs/pull/264 got merged instead. > >/close > > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tengqm commented 2 years ago

@pohly Thanks for your help anyway.