search

kubernetes-sigs / reference-docs

Tools to build reference documentation for Kubernetes APIs and CLIs.
Apache License 2.0
90 stars 105 forks source link

Update go module for 1.23 component reference #264

Closed tengqm closed 2 years ago

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/reference-docs/blob/master/OWNERS)~~ [tengqm] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sftim commented 2 years ago

I'm afraid I don't know how to verify if this change is appropriate / correct.

sftim commented 2 years ago

/unassign

kbhawkey commented 2 years ago

Hi @tengqm . Should the component pages build with Go 1.17? I built several kubeadm files with the component build? Is this correct? Thanks.

kbhawkey commented 2 years ago

I used these updates to build the component tool pages (not sure if correct): https://github.com/kbhawkey/reference-docs/blob/0565d9c642284907fe577530d145071b1f86af74/gen-compdocs/go.mod

tengqm commented 2 years ago

@kbhawkey I'm not sure we need to include a complete list of indirectly depended packages in go.mod. Usually I'd only add whatever package we reference directly in the Go source and leave the rest to the go mod system. Additional packages may be needed if go build is unhappy with the package list we provided.

kbhawkey commented 2 years ago

/lgtm