kubernetes-sigs / reference-docs

Tools to build reference documentation for Kubernetes APIs and CLIs.
Apache License 2.0
90 stars 105 forks source link

Fix nits in the config API generator #269

Closed tengqm closed 2 years ago

tengqm commented 2 years ago

This PR updates the templates so that we are outputing references only for the relevant types. This is to fix a nit where in some outputs (e.g. kube-proxy-config), irrelevant type definitions got sneaked in. A better solution would be to export the resource group name into the configuration file. However, that would be trickier to maintain than this workaround.

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/reference-docs/blob/master/OWNERS)~~ [tengqm] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kbhawkey commented 2 years ago

👀

kbhawkey commented 2 years ago

👀

kbhawkey commented 2 years ago

Reviewed Go package name updates, minor HTML formatting changes, and checks to only display relevant types. /lgtm