Fix component reference generator

kubernetes-sigs / reference-docs

Tools to build reference documentation for Kubernetes APIs and CLIs.

Apache License 2.0

88 stars 103 forks source link

Fix component reference generator #281

Closed tengqm closed 2 years ago

tengqm commented 2 years ago

There are some command line arguments (e.g. default-not-ready-toleration-seconds) registered for the kube-apiserver as GLOBAL flags. Such kind of flag registration is somehow impacting the kube-proxy command line flags. This PR separates the proxy command parsing into a separate main file so that API server args are not impacting the kube-proxy module.

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/reference-docs/blob/master/OWNERS)~~ [tengqm] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kbhawkey commented 2 years ago

Thanks @tengqm . /lgtm