search

kubernetes-sigs / reference-docs

Tools to build reference documentation for Kubernetes APIs and CLIs.
Apache License 2.0
88 stars 103 forks source link

Improve the ConfigAPI reference generator #309

Closed tengqm closed 1 year ago

tengqm commented 1 year ago

This PR improves the detection of exposed types by including the "closest" comment as well because some types are not strictly following the implicit protocols. We also relax the constraint for filtering "exported" types. For example, the (Kube)Config type in the "v1" group should be exposed when parsing the client-go package.

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/reference-docs/blob/master/OWNERS)~~ [tengqm] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment