search

kubernetes-sigs / reference-docs

Tools to build reference documentation for Kubernetes APIs and CLIs.
Apache License 2.0
87 stars 102 forks source link

[gen-resourcesdocs] fix Go lint issues, improve error handling #330

Closed xrstf closed 7 months ago

xrstf commented 10 months ago

This PR fixes a bunch of general linting issues and adds extra error handling. I also restructed the go.mod a bit to highlight the direct dependencies.

tengqm commented 10 months ago

/approve Leave a lgtm to other reviewers.

kbhawkey commented 7 months ago

@feloy , do you have time to review these changes? Thanks

k8s-ci-robot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy, tengqm, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/reference-docs/blob/master/OWNERS)~~ [feloy,tengqm] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kbhawkey commented 7 months ago

/lgtm