search

kubernetes-sigs / reference-docs

Tools to build reference documentation for Kubernetes APIs and CLIs.
Apache License 2.0
87 stars 102 forks source link

[gen-kubectldocs] fix Go lint issues, improve error handling #331

Closed xrstf closed 10 months ago

xrstf commented 10 months ago

This PR fixes a bunch of general linting issues and adds extra error handling. My favorite improvement is the error message for when no --kubernetes-version flag was given: Previously it read "must specifiy --toc-file", which isn't even a real flag. :)

tengqm commented 10 months ago

Overall looks good. /approve

k8s-ci-robot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/reference-docs/blob/master/OWNERS)~~ [tengqm] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tengqm commented 10 months ago

/lgtm