kubernetes-sigs / release-sdk

Interfaces and implementations for building Kubernetes releases.
Apache License 2.0
16 stars 29 forks source link

Add e2e test for file signing #376

Closed elsesiy closed 1 month ago

elsesiy commented 2 months ago

Generates a test file from the GHA workflow that gets signed in the e2e test similar to image signing

What type of PR is this?

/kind cleanup

Which issue(s) this PR fixes:

Fix #93

Special notes for your reviewer:

Since the test suite uses keyless signing, I haven't fully tested the patch using the existing workflow. There's a few options that I can think of:

Does this PR introduce a user-facing change?

NONE

k8s-ci-robot commented 2 months ago

Welcome @elsesiy!

It looks like this is your first PR to kubernetes-sigs/release-sdk 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/release-sdk has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 2 months ago

Hi @elsesiy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
saschagrunert commented 2 months ago

Thanks for picking up that work! :pray:

elsesiy commented 2 months ago

Thanks for picking up that work! :pray:

You're welcome! Are you ok with me updating the workflow to run e2e on PRs as well or should I create a separate demo repo to test?

saschagrunert commented 2 months ago

Are you ok with me updating the workflow to run e2e on PRs as well

Yes, that sounds fine to me.

elsesiy commented 1 month ago

@saschagrunert I pushed the changes, would you mind taking a look? Thanks!

saschagrunert commented 1 month ago

/ok-to-test

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elsesiy, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/release-sdk/blob/main/OWNERS)~~ [saschagrunert] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment