search

kubernetes-sigs / release-sdk

Interfaces and implementations for building Kubernetes releases.
Apache License 2.0
16 stars 29 forks source link

Fix e2e workflow syntax #379

Open elsesiy opened 1 month ago

elsesiy commented 1 month ago

The workflow syntax in #93 was incorrect, with is not allowed for run steps

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: elsesiy Once this PR has been reviewed and has the lgtm label, please assign justaugustus for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/release-sdk/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 1 month ago

Hi @elsesiy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
saschagrunert commented 1 month ago

/ok-to-test

elsesiy commented 1 month ago

@saschagrunert Since there is not semantic difference between the current signer initialization code and the previous implementation (ref) other than moving it to a helper func I don't think the current failure is related. Maybe the issuer regex is too restrictive?

saschagrunert commented 1 month ago

@elsesiy yeah it seems that the tests itself are broken somehow. :thinking: