kubernetes-sigs / release-team-shadow-stats

Kubernetes release team shadow program application analysis
Apache License 2.0
14 stars 6 forks source link

Refactor to inject new auto generated dummy data #5

Closed leonardpahlke closed 2 years ago

leonardpahlke commented 2 years ago

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds dummy data generation to the project that can be used to show how the project works and in the future to test functionality.

New files:

New folders:

(side note) with this PR the panda dataframe is no longer used after reading the excel file (load_data.py/load_data() returns not a dataframe anymore, but rather a class representing applicant data applicants.py/Applicants). This allows testdata injection without writing the testdata first into a excel file.

Which issue(s) this PR fixes:

Fixes #3 Fixes #2

Special notes for your reviewer:

ref tracking issue: #4

Does this PR introduce a user-facing change?

Added flag 'test' to generate dummy applicant data

cc @justaugustus @saschagrunert @puerco

leonardpahlke commented 2 years ago

dont get overwhelmed by all files under the folder example/ :smile:

Verolop commented 2 years ago

/lgtm /approve

Verolop commented 2 years ago

/assign @puerco

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leonardpahlke, saschagrunert, Verolop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/release-team-shadow-stats/blob/main/OWNERS)~~ [saschagrunert] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment