search

kubernetes-sigs / scheduler-plugins

Repository for out-of-tree scheduler plugins based on scheduler framework.
Apache License 2.0
1.09k stars 502 forks source link

Failure to create NetworkTopology resource from example #793

Open dmitsh opened 3 weeks ago

dmitsh commented 3 weeks ago

Area

Other components

No response

What happened?

I'm following the documentation, but I cannot not deploy NetworkTopology resource from this example.

Here is what I did:

  1. Deployed the plugins: 
    $ cd kubernetes-sigs/scheduler-plugins/manifests/install/charts
$ helm install --repo https://scheduler-plugins.sigs.k8s.io/ scheduler-plugins scheduler-plugins
  2. Verified CRD 
    $ kubectl get crd networktopologies.networktopology.diktyo.x-k8s.io
NAME                                                CREATED AT
networktopologies.networktopology.diktyo.x-k8s.io   2024-08-19T18:50:00Z
  3. Replaced scheduling.sigs.x-k8s.io/v1alpha1 with networktopology.diktyo.x-k8s.io/v1alpha1 in the NetworkTopology example, otherwise this CRD is not found
  4. Deployed NetworkTopology, got an error: 
    Error from server (BadRequest): error when creating "nw-aware.yaml": NetworkTopology in version "v1alpha1" cannot be handled as a NetworkTopology: strict decoding error: unknown field "spec.configMapName", unknown field "spec.weights[0].costList"

What did you expect to happen?

I expect correct documentation and working example

How can we reproduce it (as minimally and precisely as possible)?

No response

Anything else we need to know?

No response

Kubernetes version

```console $ kubectl version # paste output here ``` Client Version: v1.29.7 Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3 Server Version: v1.29.7

Scheduler Plugins version

v0.29.7
Huang-Wei commented 3 weeks ago

cc @jpedro1992

jpedro1992 commented 3 weeks ago

Dear @dmitsh,

Thank you for your interest in Diktyo and its network-aware plugins. The guide might be outdated since it is based on the first version of the plugins and the CRDs have been updated since then. I need to double-check this and update it.

In the meantime, I have created two tutorials about Diktyo and its plugins. Could you please follow one of these and let me know if you encounter issues? For one of them, I created a helm chart that deploys all CRDs and components needed to run the network-aware scheduler as an additional scheduler.

Tutorial ICIN 2024 - includes helm chart Tutorial Netsoft 2023 - includes a guide for deploying each component individually Repo for Helm Chart