Open omerap12 opened 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 35.71%. Comparing base (
87f51ec
) to head (a026885
). Report is 21 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hey @sstarcher any update on this one?
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: omerap12, sstarcher Once this PR has been reviewed and has the lgtm label, please assign tam7t for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
What type of PR is this? Adding option to separate out toleration for daemonset and crd upgrade hook. The following values.yaml file:
Will generate the following manifests:
Added backward compatibility by defaulting to the linux.tolerations when no explicit tolerations are provided. with the default values we get:
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged): Fixes #1535Special notes for your reviewer:
TODOs: