search

kubernetes-sigs / secrets-store-csi-driver

Secrets Store CSI driver for Kubernetes secrets - Integrates secrets stores with Kubernetes via a CSI volume.
https://secrets-store-csi-driver.sigs.k8s.io/
Apache License 2.0
1.24k stars 290 forks source link

refactor: cleanup unused err check #1546

Closed aramase closed 1 month ago

aramase commented 3 months ago

/kind cleanup

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/secrets-store-csi-driver/blob/main/OWNERS)~~ [aramase] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 35.80%. Comparing base (bf86dbf) to head (9548c23). Report is 33 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1546 +/- ## ========================================== - Coverage 36.58% 35.80% -0.79% ========================================== Files 63 63 Lines 4532 3754 -778 ========================================== - Hits 1658 1344 -314 + Misses 2730 2267 -463 + Partials 144 143 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nilekhc commented 1 month ago

/lgtm