feat: handles sha string in tag

kubernetes-sigs / secrets-store-csi-driver

Secrets Store CSI driver for Kubernetes secrets - Integrates secrets stores with Kubernetes via a CSI volume.

https://secrets-store-csi-driver.sigs.k8s.io/

Apache License 2.0

1.21k stars 280 forks source link

feat: handles sha string in tag #1565

Closed nilekhc closed 1 week ago

nilekhc commented 1 week ago

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged): Fixes https://github.com/kubernetes-sigs/secrets-store-csi-driver/issues/1539

Special notes for your reviewer:

TODOs:

[ ] squashed commits
[ ] includes documentation
[ ] adds unit tests

nilekhc commented 1 week ago

To keep this change simple, I would be fine with just dropping all the semver checks altogether. The checks are for really old versions and no longer relevant for the project because they're unsupported releases/chart versions.

I have removed it. PTAL.

k8s-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase, nilekhc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/secrets-store-csi-driver/blob/main/OWNERS)~~ [aramase] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment