kubernetes-sigs / secrets-store-csi-driver

Secrets Store CSI driver for Kubernetes secrets - Integrates secrets stores with Kubernetes via a CSI volume.
https://secrets-store-csi-driver.sigs.k8s.io/
Apache License 2.0
1.23k stars 287 forks source link

Feature request: Support OpenBao as a `spec.provider` in `secrets-store.csi.x-k8s.io/v1` #1580

Open jessebot opened 1 month ago

jessebot commented 1 month ago

Describe the solution you'd like

I'd like to propose we please add support for OpenBao as a spec.provider.

Anything else you would like to add

OpenBao, a fork of Vault before the license change to BSL, is a Linux Foundation Project and is being actively maintained by a set of kind maintainers and collaborators. We recently forked the Vault CSI Provider repo and started testing it, but I ran into an issue where OpenBao is not recognized as a valid provider, and so I opened this issue to track it: https://github.com/openbao/openbao-csi-provider/issues/5

We're happy to support this effort by submitting PRs to accommodate this. As I'm personally a little new to this repo, if you could point me in the right direction, I am happy to start on a draft PR :) Most everything should be the same as Vault for now, but with the name OpenBao as essentially an alias.

Let me know if you have follow up questions! Happy to help/collaborate 🙏

Environment

aramase commented 1 month ago

Hello 👋🏻

Thanks for reaching out and welcome to the community!

There are no changes required in the driver to support a provider. As long as the provider implements the RPC required for communication between driver-provider it should work.

In terms of getting the provider added to the supported provider list here, these are the steps you would need to follow: https://secrets-store-csi-driver.sigs.k8s.io/providers. We would be happy to work with you!

Feel free to reach out on slack if you have any questions.