Open AlexanderStocks opened 3 weeks ago
I am happy to pick this up, let me know.
Thanks for reporting it @AlexanderStocks. I think it would be a good idea to check the Status Condition logic as a whole to make sure there are not any gaps. I have opened uber level issue for it.
/assign
What steps did you take and what happened: VSCode detected an unused write to field Message in
secretsync_controller.go
on line 277failedCondition.Message = err.Error()
. We are incorrectly updating the status condition, the error is lost.What did you expect to happen: I would expect the error to be passed to the
updateStatusConditions
and set thecondition.Reason
there accordingly.Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]
Which provider are you using: [e.g. Azure Key Vault, HashiCorp Vault, etc. Have you checked out the provider's repo for more help?]
Environment:
kubectl version
): Client Version: v1.28.3 Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3 Server Version: v1.29.2