kubernetes-sigs / sig-storage-lib-external-provisioner

Apache License 2.0
547 stars 173 forks source link

Cherry-pick fix indefinite stuck Pending pod on a deleted node #141

Closed sunnylovestiramisu closed 1 year ago

sunnylovestiramisu commented 1 year ago

Cherry-pick https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner/pull/139

jsafrane commented 1 year ago

/retest

git fetch https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner.git v8.0.1 - it should fetch from https://github.com/sunnylovestiramisu/sig-storage-lib-external-provisioner/tree/v8.0.1, not kubernetes-sigs

jsafrane commented 1 year ago

This is the failure that matters:

--- FAIL: TestTopologyParams (1.01s) --- FAIL: TestTopologyParams/provision_with_selected_node,_but_node_does_not_exist (0.20s) controller_test.go:935: did not expect a Provision() call but got at least 1

jsafrane commented 1 year ago

/retest

I've no clue what's wrong with gofmt. It runs verify-gofmt.sh in container golang:1.19. And it complains about files that are not part of this PR.

sunnylovestiramisu commented 1 year ago

/retest

sunnylovestiramisu commented 1 year ago

Fixed the unit test but the verify-gofmt.sh is still failing

sunnylovestiramisu commented 1 year ago

Now it is complaining about:

PATH=$(go env GOPATH)/bin:$PATH repo-infra/verify/verify-boilerplate.sh
/usr/bin/env: 'python': No such file or directory
sunnylovestiramisu commented 1 year ago

There is no change in k/k's verify-boilerplate.sh

msau42 commented 1 year ago

/lgtm /approve

sunnylovestiramisu commented 1 year ago

/assign @jsafrane can you approve this? Thanks!

jsafrane commented 1 year ago

/approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, msau42, sunnylovestiramisu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner/blob/release-8.0/OWNERS)~~ [jsafrane] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment