Closed sunnylovestiramisu closed 1 year ago
/retest
git fetch https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner.git v8.0.1
- it should fetch from https://github.com/sunnylovestiramisu/sig-storage-lib-external-provisioner/tree/v8.0.1, not kubernetes-sigs
This is the failure that matters:
--- FAIL: TestTopologyParams (1.01s) --- FAIL: TestTopologyParams/provision_with_selected_node,_but_node_does_not_exist (0.20s) controller_test.go:935: did not expect a Provision() call but got at least 1
/retest
I've no clue what's wrong with gofmt. It runs verify-gofmt.sh in container golang:1.19
. And it complains about files that are not part of this PR.
/retest
Fixed the unit test but the verify-gofmt.sh is still failing
Now it is complaining about:
PATH=$(go env GOPATH)/bin:$PATH repo-infra/verify/verify-boilerplate.sh
/usr/bin/env: 'python': No such file or directory
There is no change in k/k's verify-boilerplate.sh
/lgtm /approve
/assign @jsafrane can you approve this? Thanks!
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jsafrane, msau42, sunnylovestiramisu
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Cherry-pick https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner/pull/139