use metrics from custom instance, instead of the static one

[noam-codefresh]

meant to fix #149 . please let me know if it requires any more changes.

[linux-foundation-easycla[bot]]

The committers listed above are authorized under a signed CLA.

• :white_check_mark: login: noam-codefresh / name: Noam Gal (9afb5e54ee5c39c20b1b6c33cb8845db5aeac353, 2ea623f7281f4a87ec2fd6de6fbc8616eb6c2feb, cfed6ea2e025fbff0945757d7564a800940283a3)

[k8s-ci-robot]

Welcome @noam-codefresh!

It looks like this is your first PR to kubernetes-sigs/sig-storage-lib-external-provisioner 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/sig-storage-lib-external-provisioner has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

[k8s-ci-robot]

Hi @noam-codefresh. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[saad-ali]

/ok-to-test

[saad-ali]

/assign @wongma7 /assign @pohly

Matt or Patrick, could one of you PTAL?

[noam-codefresh]

any chance anyone will take a look at this tiny PR?

[jsafrane]

The PR may be tiny, but it may break great things! :-)

[noam-codefresh]

@jsafrane - i've made the requested changes.

--- FAIL: TestTopologyParams (1.01s)
    --- FAIL: TestTopologyParams/provision_with_selected_node,_but_node_does_not_exist (0.20s)
        /Users/noamgal/source/sig-storage-lib-external-provisioner/controller/controller_test.go:971: did not expect a Provision() call but got at least 1

seems like this specific test is flaky. i'm running it locally, and once every 4-5 attempts, it fails. is it caused by changes in my PR, or is it a known flaky test?

[pohly]

is it caused by changes in my PR, or is it a known flaky test?

You can test with stress with and without your PR to find out. See https://github.com/kubernetes/community/blob/master/contributors/devel/sig-testing/flaky-tests.md (EDIT - why is our current page not the first search hit, or even among the first 10?! Sigh.)

[noam-codefresh]

is it caused by changes in my PR, or is it a known flaky test?

You can test with stress with and without your PR to find out. See https://github.com/kubernetes/community/blob/master/contributors/devel/sig-testing/flaky-tests.md (EDIT - why is our current page not the first search hit, or even among the first 10?! Sigh.)

ok, i executed (on the master branch)

go test ./controller -race -c
stress ./controller.test -test.run TestTopologyParams

and after running for a while, i am getting

35s: 289 runs so far, 259 failures (89.62%)

quite a high failure rate.

[jsafrane]

I've filed https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner/issues/160 /retest

[jsafrane]

/lgtm /approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, noam-codefresh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner/blob/master/OWNERS)~~ [jsafrane] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment