Closed carlory closed 7 months ago
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
/test pull-sig-storage-lib-external-provisioner-unit
/assign @jsafrane
A flaking test on TestTopologyParams will be fixed by https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner/pull/165
I'm looking at another flaking test.
fatal error: concurrent map read and map write
It shouldn't relate to changes made by this PR. @deepakkinni
/test pull-sig-storage-lib-external-provisioner-unit
/lgtm
@jsafrane any concerns switching from update to patch?
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: carlory, jsafrane
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm cancel
Please update examples/hostpath-provisioner/rbac.yaml with the new permissions.
@jsafrane added.
/lgtm
See https://github.com/kubernetes-csi/external-provisioner/pull/1155#issuecomment-1989048905
/cc @deepakkinni @xing-yang @msau42