kubernetes-sigs / sig-storage-lib-external-provisioner

Apache License 2.0
547 stars 173 forks source link

use patch method instead when update finalizer to PV #164

Closed carlory closed 7 months ago

carlory commented 8 months ago

See https://github.com/kubernetes-csi/external-provisioner/pull/1155#issuecomment-1989048905

/cc @deepakkinni @xing-yang @msau42

Action required: Using patch to update finalizers. Any external-provisioner now needs permission rules to patch PersistentVolumes. Please update RBAC rules of your provisioner.
k8s-ci-robot commented 8 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

carlory commented 8 months ago

/test pull-sig-storage-lib-external-provisioner-unit

xing-yang commented 8 months ago

/assign @jsafrane

carlory commented 8 months ago

A flaking test on TestTopologyParams will be fixed by https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner/pull/165

carlory commented 8 months ago

I'm looking at another flaking test.

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_sig-storage-lib-external-provisioner/164/pull-sig-storage-lib-external-provisioner-unit/1768450559246864384

fatal error: concurrent map read and map write

It shouldn't relate to changes made by this PR. @deepakkinni

carlory commented 8 months ago

/test pull-sig-storage-lib-external-provisioner-unit

xing-yang commented 7 months ago

/lgtm

@jsafrane any concerns switching from update to patch?

jsafrane commented 7 months ago

/approve

k8s-ci-robot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner/blob/master/OWNERS)~~ [jsafrane] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jsafrane commented 7 months ago

/lgtm cancel

Please update examples/hostpath-provisioner/rbac.yaml with the new permissions.

carlory commented 7 months ago

@jsafrane added.

jsafrane commented 7 months ago

/lgtm