kubernetes-sigs / sig-storage-lib-external-provisioner

Apache License 2.0
547 stars 173 forks source link

Update to Kubernetes 1.30 #167

Closed jsafrane closed 6 months ago

jsafrane commented 7 months ago

Update all Kubernetes libraries to 1.30 and go to 1.22. Fix our code accordingly (v1.ResourceRequirements -> v1.VolumeResourceRequirements.

When at it:

@xing-yang @msau42

Update to Kubernetes 1.30 and go 1.22. Removed gometalinter.
k8s-ci-robot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner/blob/master/OWNERS)~~ [jsafrane] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jsafrane commented 7 months ago

I'm updating go version in https://github.com/kubernetes/test-infra/pull/32493

xing-yang commented 7 months ago

CI failed.

jsafrane commented 7 months ago

/retest

jsafrane commented 7 months ago

Damn, I need to install gometalinter in CI somehow.

/bin/sh: 1: gometalinter: not found

jsafrane commented 6 months ago

I removed the whole gometalinter, I did not make it work in go 1.22 easily and I don't think it's that useful either.

xing-yang commented 6 months ago

/lgtm