search

kubernetes-sigs / sig-storage-lib-external-provisioner

Apache License 2.0
537 stars 174 forks source link

make test: also test that building the example works #81

Open pohly opened 4 years ago

pohly commented 4 years ago

The prow jobs don't check that examples/hostpath-provisioner is in a healthy state.

Either "make test" or "make build" should cover that. I'm leaning to "make test", but that's debatable.

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

pohly commented 3 years ago

/remove-lifecycle stale

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

pohly commented 3 years ago

/remove-lifecycle stale /lifecycle frozen

jsafrane commented 1 year ago

/help

k8s-ci-robot commented 1 year ago

@jsafrane: This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to [this](https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner/issues/81): >/help Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
thisisharrsh commented 2 months ago

Thank you for highlighting this issue.

I think there can be two ways to address this issue,

--> Integrate make test: This would run tests to ensure functionality and correctness. --> Integrate make build: This would ensure the example builds successfully, though it won't verify runtime behavior.

jsafrane commented 1 month ago

We need to ensure that examples/hostpath-provisioner at least builds. Even that would be a great improvement. If you can, adding an e2e test that checks the example even works would be awesome, but that requires setting up a Kubernetes cluster for the e2e job.