search

kubernetes-sigs / sig-windows-dev-tools

This is a batteries included local development environment for Kubernetes on Windows.
Apache License 2.0
80 stars 46 forks source link

Document variables file in sync/shared in README.md #149

Closed dougsland closed 2 years ago

dougsland commented 2 years ago

Question: What's the reason to have two variables file?

$ ls sync/shared/va*
sync/shared/variables-lite.yaml 
sync/shared/variables.yaml

Question: What's the meaning for each entry in the file?

# cat variables.yaml | grep ": " | egrep -v ^\#
kubernetes_sha: "286709307da5adb62e78d989b7ed846355d5c88e"
kubernetes_compatibility:  "1.21.2"
overwrite_windows_bins: "false"
kubelet_path:  "./sync/windows/bin/kubelet.exe"
kubeproxy_path:  "./sync/windows/bin/kube-proxy.exe"
windows_node_ip: "10.20.30.11"
k8s_linux_registry: "gcr.io/k8s-staging-ci-images"
k8s_linux_kubelet_deb:  "1.21.0"
k8s_linux_apiserver: "ci/v1.22.0-alpha.3.31+a3abd06ad53b2f"
k8s_linux_kubelet_nodeip: "10.20.30.10"
overwrite_linux_bins: false
linux_ram: 4096
linux_cpus: 4
windows_ram: 6048
windows_cpus: 4
cni: "antrea"

Question: Why the variables-lite.yaml contain different number of entries from variables.yaml?

16 entries in variables.yaml 

       # cat variables.yaml | grep ": " | egrep -v ^\# | wc -l
      16

13 entries in variables-lite.yaml 

      # cat variables-lite.yaml | grep ": " | egrep -v ^\# | wc -l
      13

Question: Is variables-lite.yaml working at all?

Question: Can we have reduced number of entries ? Which values it will assume?

See-also: https://github.com/kubernetes-sigs/sig-windows-dev-tools/pull/148

dougsland commented 2 years ago

@knabben @aravindhp could you please add tag good-for-first-issue? I don't have perms.

aravindhp commented 2 years ago

/label good-for-first-issue

k8s-ci-robot commented 2 years ago

@aravindhp: The label(s) /label good-for-first-issue cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor

In response to [this](https://github.com/kubernetes-sigs/sig-windows-dev-tools/issues/149#issuecomment-1014782516): >/label good-for-first-issue Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
aravindhp commented 2 years ago

@dougsland looks that label is not available

dougsland commented 2 years ago

/good-first-issue

k8s-ci-robot commented 2 years ago

@dougsland: This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/kubernetes-sigs/sig-windows-dev-tools/issues/149): >/good-first-issue Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dougsland commented 2 years ago

@aravindhp looks like it's a different command, thanks anyway :) teamwork++