kubernetes-sigs / sig-windows-dev-tools

This is a batteries included local development environment for Kubernetes on Windows.
Apache License 2.0
80 stars 46 forks source link

Use ci/latest as image for k8s_linux_apiserver #152

Closed dougsland closed 2 years ago

dougsland commented 2 years ago

Issue:

The CI Image for APIServer is static is require manually change for updating.

Steps to change it:

$ vi sync/shared/variables.yaml
k8s_linux_apiserver: "ci/v1.22.0-alpha.3.31+a3abd06ad53b2f"   <---- removed
k8s_linux_apiserver: "ci/latest"   <------ added

How to test after the change?

# git clone https://github.com/kubernetes-sigs/sig-windows-dev-tools.git
< do the changes listed above>
# sig-windows-dev-tools# make 2

Goal: make sure it's using the latest kubernetes image for CI without breaking the build process.

See discussion here for more info: https://github.com/kubernetes-sigs/sig-windows-dev-tools/pull/148

dougsland commented 2 years ago

/good-first-issue

k8s-ci-robot commented 2 years ago

@dougsland: This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/kubernetes-sigs/sig-windows-dev-tools/issues/152): >/good-first-issue Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dougsland commented 2 years ago

@knabben already fixed that using stable:

k8s_linux_apiserver="stable-${kubernetes_version}"