search

kubernetes-sigs / sig-windows-dev-tools

This is a batteries included local development environment for Kubernetes on Windows.
Apache License 2.0
80 stars 46 forks source link

controlplane: add alias, krew plugins and kubetail #170

Closed dougsland closed 2 years ago

dougsland commented 2 years ago

The sig-windows-dev-tools distro is very helpful for developers, let's add additional tools to make life even easier.

   
This patch adds:
            - kubectl krew
            - krew plugin iexec
            - krew plugin ctx
            - krew plugin view-secret
            - kubetail
            - alias k for kubectl

GitHub-Issue: https://github.com/kubernetes-sigs/sig-windows-dev-tools/issues/166 Signed-off-by: Douglas Schilling Landgraf dlandgra@redhat.com

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dougsland To complete the pull request process, please assign jayunit100 after the PR has been reviewed. You can assign the PR to them by writing /assign @jayunit100 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/sig-windows-dev-tools/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dougsland commented 2 years ago

Can't you copy over the kubeconfig from the controlplane and interact with the cluster from your local system? At least that is how I have been working.

scp -i .vagrant/machines/controlplane/virtualbox/private_key vagrant@$ControlPlaneIP:.kube/config /tmp/config

As this is a test env, debugging directly in the node helps.

Not sure if we want to make all these client specific in the controlplane.

I agree but we already have kubectl there right? Enabling krew won't hurt much (IMHO).

aravindhp commented 2 years ago

As this is a test env, debugging directly in the node helps.

For some parts yes, but anything do with kubectl should be achievable from your local system.

I agree but we already have kubectl there right? Enabling krew won't hurt much (IMHO).

I would take the alternative approach and say we should be removing kubectl 😃

However if @knabben @jayunit100 @marosset @jsturtevant think this is fine, I am okay with it.

dougsland commented 2 years ago

As this is a test env, debugging directly in the node helps.

For some parts yes, but anything do with kubectl should be achievable from your local system.

I agree but we already have kubectl there right? Enabling krew won't hurt much (IMHO).

I would take the alternative approach and say we should be removing kubectl smiley

Probably that's the right thing to do. Going to close this one for now. If people think this is useful they can re-open anytime.