Closed luthermonson closed 2 years ago
Welcome @luthermonson!
It looks like this is your first PR to kubernetes-sigs/sig-windows-dev-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/sig-windows-dev-tools has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
fixed #200
whoa !!!!!!!!!!!
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: aravindhp, luthermonson
The full list of commands accepted by this bot can be found here.
The pull request process is described here
can you test this and merge @knabben !??
testing..
/lgtm
Windows desktop works as linux/macosx you just need to install VirtualBox and Vagrant on the host and call out to vagrant.exe in WSL. This is the easiest way to get the windows desktop working. The harder way so you dont have to use WSL is to rewrite the Makefile, build.sh and fetch.sh in PowerShell... or you could use Mage and write it once in go for all operating systems (my preferred method).