Ensure copied Kubernetes binaries are executable

kubernetes-sigs / sig-windows-dev-tools

This is a batteries included local development environment for Kubernetes on Windows.

Apache License 2.0

80 stars 46 forks source link

Ensure copied Kubernetes binaries are executable #257

Closed mloskot closed 1 year ago

mloskot commented 1 year ago

Currently, the binaries are chmod-ed during download phase

https://github.com/kubernetes-sigs/sig-windows-dev-tools/blob/171f2ca763ea90d19e996bcc28a055ba1086c09b/build.sh#L29

which does not seem to be the best place to do it, besides this step may not be effective (i.e. is missing) when run on Windows host. That is, if binaries are downloaded and copied by other means than the Makefile, e.g. make.ps1 from #254, then those binaries are missing executable bit.

Extracted from bundle

jayunit100 commented 1 year ago

/lgtm /approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jayunit100, mloskot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/sig-windows-dev-tools/blob/master/OWNERS)~~ [jayunit100] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment